Matthias Clasen [Sun, 3 May 2020 04:09:18 +0000 (00:09 -0400)]
listboxrow: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore.
See #2681
Matthias Clasen [Sun, 3 May 2020 00:53:40 +0000 (20:53 -0400)]
flowboxchild: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore.
See #2681
Matthias Clasen [Sat, 2 May 2020 22:56:57 +0000 (18:56 -0400)]
revealer: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore. This requires
us to move get_request_mode and compute_expand down.
See #2681
Matthias Clasen [Sat, 2 May 2020 21:02:42 +0000 (17:02 -0400)]
Use gtk_revealer_set_child throughout
Replace all uses of gtk_container_add on revealers
with gtk_revealer_set_child.
Matthias Clasen [Sat, 2 May 2020 20:50:11 +0000 (16:50 -0400)]
revealer: Add a child property
Matthias Clasen [Sat, 2 May 2020 19:17:20 +0000 (15:17 -0400)]
window: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore. This requires
us to move get_request_mode and compute_expand down.
Update the accessible implementation to match, remove
remnants of container implementations in GtkWindow
subclasses, and fix livecycle issues around destroy
vs dispose in GtkAssistant.
After this commit, using gtk_container_add on window
subclasses is not allowed anymore, but adding childing
with <child> in ui files still works.
See #2681
Matthias Clasen [Sat, 2 May 2020 21:26:54 +0000 (17:26 -0400)]
Use gtk_window_set_child throughout
Replace all uses of gtk_container_add on windows
by gtk_window_set_child.
Matthias Clasen [Sat, 2 May 2020 15:33:10 +0000 (11:33 -0400)]
window: Add a child property
Matthias Clasen [Sat, 2 May 2020 14:30:46 +0000 (10:30 -0400)]
button: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore. This requires
us to move get_request_mode and compute_expand down.
We have to implement GtkBuildable, in order to keep
the <child> element in ui files working for buttons.
See #2681
Matthias Clasen [Mon, 4 May 2020 16:28:21 +0000 (12:28 -0400)]
css testsuite: Remove an obsolete test
This was testing something that shouldn't be possible
anyway: Adding more than one child to a bin. With the
bin removal, this now just overrides the child so
only one child is left in the end.
Just remove the test.
Matthias Clasen [Mon, 4 May 2020 16:26:36 +0000 (12:26 -0400)]
css tests: Update expected results
Now that GtkCheckButton is using a box layout,
we are no longer reordering the css nodes according
to text direction.
Matthias Clasen [Sat, 2 May 2020 14:29:59 +0000 (10:29 -0400)]
checkbutton: Modernize
Stop implementing GtkContainer, and just use a box layout
instead of doing our own thing manually.
Matthias Clasen [Sat, 2 May 2020 07:05:19 +0000 (03:05 -0400)]
Use gtk_button_set_child throughout
Replace all uses of gtk_container_add on buttons
by gtk_button_set_child.
Matthias Clasen [Sat, 2 May 2020 06:45:09 +0000 (02:45 -0400)]
button: Add a child property
Matthias Clasen [Sat, 2 May 2020 05:48:52 +0000 (01:48 -0400)]
scrolledwindow: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore. This requires
us to move get_request_mode and compute_expand down.
We have to implement GtkBuildable, in order to keep
the <child> element in ui files working for aspect
frames.
See #2681
Matthias Clasen [Sat, 2 May 2020 04:51:20 +0000 (00:51 -0400)]
Use gtk_scrolled_window_set_child throughout
Replace all uses of gtk_container_add on popovers
by gtk_scrolled_window_set_child.
Matthias Clasen [Sat, 2 May 2020 04:17:25 +0000 (00:17 -0400)]
scrolledwindow: Add a child property
Matthias Clasen [Sat, 2 May 2020 02:35:31 +0000 (22:35 -0400)]
popover: Derive from GtkWidget
Matthias Clasen [Sat, 2 May 2020 02:22:20 +0000 (22:22 -0400)]
Use gtk_popover_set_child throughout
Replace all uses of gtk_container_add on popovers
by gtk_popover_set_child.
Matthias Clasen [Fri, 1 May 2020 22:24:15 +0000 (18:24 -0400)]
popover: Add a child property
Matthias Clasen [Fri, 1 May 2020 20:53:14 +0000 (16:53 -0400)]
viewport: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore. This requires
us to move get_request_mode and compute_expand down.
We have to implement GtkBuildable in order to keep
the <child> element working for viewports in ui files.
See #2681
Matthias Clasen [Fri, 1 May 2020 19:43:09 +0000 (15:43 -0400)]
Use gtk_viewport_set_child throughout
Replace all uses of gtk_container_add on viewports
by gtk_viewport_set_child.
Matthias Clasen [Fri, 1 May 2020 19:40:50 +0000 (15:40 -0400)]
viewport: Add a child property
Matthias Clasen [Sat, 2 May 2020 15:05:27 +0000 (11:05 -0400)]
aspect frame use fixup
Matthias Clasen [Sat, 2 May 2020 15:05:15 +0000 (11:05 -0400)]
fishbow: fixup premature popover
Matthias Clasen [Fri, 1 May 2020 19:18:11 +0000 (15:18 -0400)]
aspectframe: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore. This requires
us to move get_request_mode and compute_expand down.
We have to implement GtkBuildable, in order to keep
the <child> element in ui files working for aspect
frames.
See #2681
Matthias Clasen [Fri, 1 May 2020 18:53:55 +0000 (14:53 -0400)]
Use gtk_aspect_frame_set_child throughout
Replace all uses of gtk_container_add on aspect frames
by gtk_aspect_frame_set_child.
Matthias Clasen [Fri, 1 May 2020 18:49:54 +0000 (14:49 -0400)]
aspectframe: Add a child property
Matthias Clasen [Fri, 1 May 2020 17:48:28 +0000 (13:48 -0400)]
frame: Derive from GtkWidget
We want to remove GtkBin and GtkContainer as they don't
provide much useful functionality anymore. This requires
us to move get_request_mode and compute_expand down.
See #2681
Matthias Clasen [Fri, 1 May 2020 17:41:22 +0000 (13:41 -0400)]
Use gtk_frame_set_child throughout
Replace all uses of gtk_container_add for
frames with gtk_frame_set_child.
Matthias Clasen [Fri, 1 May 2020 17:04:38 +0000 (13:04 -0400)]
frame: Add a child property
Matthias Clasen [Mon, 4 May 2020 20:10:46 +0000 (20:10 +0000)]
Merge branch 'wip/jimmac/notebook-focus' into 'master'
Adwaita: notebook tab focus
See merge request GNOME/gtk!1825
Matthias Clasen [Mon, 4 May 2020 19:02:40 +0000 (19:02 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1826
Jakub Steiner [Mon, 4 May 2020 18:07:38 +0000 (18:07 +0000)]
Merge branch 'wip/jimmac/colorswatch-fix' into 'master'
Adwaita: colorswatch focus rings
Closes #2695
See merge request GNOME/gtk!1827
Jakub Steiner [Mon, 4 May 2020 16:13:48 +0000 (18:13 +0200)]
Adwaita: colorswatch focus rings
- there used to be different outline color for light and dark buttons,
but it's complexity I can live without. blue focus rings fit all.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2695
Jakub Steiner [Mon, 4 May 2020 14:33:24 +0000 (16:33 +0200)]
Adwaita: notebook tab focus
- just like entries tabs need to be handled with focus-within
Jakub Steiner [Mon, 4 May 2020 15:14:55 +0000 (15:14 +0000)]
Merge branch 'wip/exalm/entries' into 'master'
Adwaita: Convert entries to the new focus rings
See merge request GNOME/gtk!1824
Matthias Clasen [Mon, 4 May 2020 14:51:11 +0000 (10:51 -0400)]
Adwaita: Style .toolbar
We don't have GtkToolbar anymore, so we are more likely
to meet a .toolbar style class, than a toolbar element.
Matthias Clasen [Mon, 4 May 2020 14:50:34 +0000 (10:50 -0400)]
widget-factory: Add .toolbar
We dropped GtkToobar, but we still want to present
something that looks the part here, so add a style
class.
Alexander Mikhaylenko [Mon, 4 May 2020 14:23:49 +0000 (19:23 +0500)]
Adwaita: Convert entries to the new focus rings
Daniel Mustieles [Mon, 4 May 2020 13:52:57 +0000 (15:52 +0200)]
Updated Spanish translation
Matthias Clasen [Mon, 4 May 2020 12:31:25 +0000 (12:31 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1823
Matthias Clasen [Sun, 3 May 2020 15:44:00 +0000 (11:44 -0400)]
testframe: Drop padding
No need to emulate features that GtkFrame no longer has.
Matthias Clasen [Sun, 3 May 2020 15:41:57 +0000 (11:41 -0400)]
frame: Fix xalign handling
SEtting a nonzero xalign on frames had no
effect, since we were always using the full
allocation with here, instead of what the label
needs. Found by using testframe for a second.
Matthias Clasen [Sun, 3 May 2020 15:39:58 +0000 (11:39 -0400)]
frame: Don't queue a resize if xalign changes
We only need to allocate children in this case.
While we touch it, rewrite the setter to modern
style.
Jakub Steiner [Mon, 4 May 2020 10:24:32 +0000 (10:24 +0000)]
Merge branch 'wip/jimmac/avoid-wobbly-windows' into 'master'
Adwaita: make transition offset more subtle
See merge request GNOME/gtk!1822
Jakub Steiner [Mon, 4 May 2020 09:29:19 +0000 (11:29 +0200)]
Adwaita: make transition offset more subtle
- be less like wobbly windows
Jakub Steiner [Mon, 4 May 2020 08:49:40 +0000 (08:49 +0000)]
Merge branch 'wip/jimmac/emphasize-focus-change' into 'master'
Adwaita: bring more attention to focus change
See merge request GNOME/gtk!1803
Cheng-Chia Tseng [Sun, 3 May 2020 13:29:03 +0000 (13:29 +0000)]
Update Chinese (Taiwan) translation
Matthias Clasen [Sun, 3 May 2020 01:10:24 +0000 (01:10 +0000)]
Merge branch 'filechooser-translation' into 'master'
filechooser: Translate type column
Closes #2690
See merge request GNOME/gtk!1816
Matthias Clasen [Sat, 2 May 2020 23:57:38 +0000 (19:57 -0400)]
filechooser: Translate type column
When the code for this was copied from nautilus,
we forgot to adapt it for running in a library
instead of an application - gettext() doesn't work
in a library.
Fixes: #2690
Matthias Clasen [Sat, 2 May 2020 20:06:08 +0000 (20:06 +0000)]
Merge branch 'wip/exalm/subtitle' into 'master'
appchooserdialog: Don't show subtitle label when subtitle is null
See merge request GNOME/gtk!1815
Alexander Mikhaylenko [Sat, 2 May 2020 18:34:58 +0000 (23:34 +0500)]
appchooserdialog: Don't show subtitle label when subtitle is null
Looks like
67822d0c9a23f6db7e816fd6466720c167dcbe7f and
3f1bd3722dd3374bef07346138a0ed9e95d3b9fe collided, and subtitle can be null
now. Add a check so that we don't end up with empty label in that case.
Yuri Chornoivan [Sat, 2 May 2020 06:27:02 +0000 (06:27 +0000)]
Update Ukrainian translation
Matthias Clasen [Fri, 1 May 2020 21:09:38 +0000 (21:09 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
docs: Add more detail to the drawing overview
See merge request GNOME/gtk!1811
Benjamin Otte [Fri, 1 May 2020 19:39:27 +0000 (19:39 +0000)]
Merge branch 'wip/exalm/headerbar-title' into 'master'
Headerbar title/subtitle cleanups
See merge request GNOME/gtk!1807
Asier Sarasua Garmendia [Fri, 1 May 2020 19:25:55 +0000 (19:25 +0000)]
Update Basque translation
Matthias Clasen [Fri, 1 May 2020 18:17:26 +0000 (14:17 -0400)]
widget-factory: Fix a typo
We wanted to move the conflicting global shortcuts
to the bubble phase, so they don't override the
entry bindings.
Matthias Clasen [Fri, 1 May 2020 16:21:42 +0000 (12:21 -0400)]
dragicon: Derive from GtkWidget
This wasn't meant to derive from GtkContainer.
Matthias Clasen [Fri, 1 May 2020 16:12:18 +0000 (12:12 -0400)]
docs: Add more detail to the drawing overview
Matthias Clasen [Fri, 1 May 2020 18:13:12 +0000 (18:13 +0000)]
Merge branch 'for-master' into 'master'
appchooserdialog: Don't show broken subtitles
See merge request GNOME/gtk!1809
Alexander Mikhaylenko [Fri, 1 May 2020 15:10:52 +0000 (20:10 +0500)]
headerbar: Document GtkBuilder child types, add a title example
Florian Müllner [Fri, 1 May 2020 15:01:34 +0000 (17:01 +0200)]
appchooserdialog: Don't show broken subtitles
Commit
07beb6dba29 made GtkAppChooserWidget useful with no content-type,
however when used in a GtkAppChooserDialog, this will lead to a confusing
"Opening (null) files" subtitle.
Fix this by omitting the subtitle altogether in that case.
Matthias Clasen [Fri, 1 May 2020 16:02:43 +0000 (16:02 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
docs: Some revisions of the input overview
See merge request GNOME/gtk!1808
Yuri Chornoivan [Fri, 1 May 2020 15:56:57 +0000 (15:56 +0000)]
Update Ukrainian translation
Alexander Mikhaylenko [Fri, 1 May 2020 13:48:03 +0000 (18:48 +0500)]
builder-tool: Rename GtkHeaderBar:custom-title to title-widget
Add a test.
Alexander Mikhaylenko [Thu, 30 Apr 2020 23:17:27 +0000 (04:17 +0500)]
headerbar: Rename custom-title to title-widget
Now that all the other title-related properties are gone, custom title can
have a more mundane name.
Alexander Mikhaylenko [Thu, 30 Apr 2020 23:04:08 +0000 (04:04 +0500)]
headerbar: Remove user-settable title
Use window title, or custom title widget if it's set. Remove 'title'
property.
Update demos and tests to set the title on the window instead of
headerbar.
Alexander Mikhaylenko [Thu, 30 Apr 2020 20:27:05 +0000 (01:27 +0500)]
headerbar: Remove subtitle
Also remove the box containing title and subtitle, as there's only one
label now.
Alexander Mikhaylenko [Thu, 30 Apr 2020 20:08:57 +0000 (01:08 +0500)]
filechooserdialog: Create title and subtitle manually
title and subtitle properties will go away in the following commits, stop
using them.
Alexander Mikhaylenko [Thu, 30 Apr 2020 19:42:37 +0000 (00:42 +0500)]
appchooserdialog: Create title and subtitle manually
title and subtitle properties will go away in the following commits, stop
using them.
Alexander Mikhaylenko [Thu, 30 Apr 2020 18:47:53 +0000 (23:47 +0500)]
headerbar: Remove has-subtitle property
Subtitle will go too in the next commit, but has-subtitle goes first as
it's broken right now anyway.
Matthias Clasen [Fri, 1 May 2020 13:26:06 +0000 (09:26 -0400)]
docs: Some revisions of the input overview
Remove some less than accurate details, and add
an illustration.
Matthias Clasen [Fri, 1 May 2020 12:02:13 +0000 (12:02 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Keynav improvements for widget-factory
See merge request GNOME/gtk!1804
Piotr Drąg [Fri, 1 May 2020 09:56:37 +0000 (11:56 +0200)]
Update POTFILES.in and POTFILES.skip
Matthias Clasen [Fri, 1 May 2020 00:08:15 +0000 (20:08 -0400)]
widget-factory: Improve demo keynav
We have example cut/copy/paste actions for which we want
the usual shortcuts to show up in the menus, but they should
not break the expected shortcuts in entries. So, move them
to a capture phase shortcut controller.
Matthias Clasen [Thu, 30 Apr 2020 23:18:09 +0000 (19:18 -0400)]
widget-factory: Add mnemonics to the stack pages
Matthias Clasen [Thu, 30 Apr 2020 23:17:34 +0000 (19:17 -0400)]
stack: Add a :use-underline property
Add GtkStackPage:use-underline, and use it when
constructing labels in the stack switcher.
Matthias Clasen [Thu, 30 Apr 2020 22:57:33 +0000 (22:57 +0000)]
Merge branch 'speed-up-event-matching' into 'master'
keymap: Cache key info
See merge request GNOME/gtk!1800
Jakub Steiner [Thu, 30 Apr 2020 20:40:21 +0000 (22:40 +0200)]
Adwaita: bring more attention to focus change
- as discussed in https://gitlab.gnome.org/GNOME/gtk/-/issues/2644 it's desirable to bring attention to what's focused. Instead of pressing `alt` just simply changing focus with `tab` can have a similar effect
Extends https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1802
Jakub Steiner [Thu, 30 Apr 2020 18:35:57 +0000 (18:35 +0000)]
Merge branch 'theme-focus-ring-mixin' into 'master'
Adwaita: Use a mixin for visible focus rings
Closes #2653
See merge request GNOME/gtk!1802
Matthias Clasen [Thu, 30 Apr 2020 04:33:06 +0000 (00:33 -0400)]
keymap: Cache key info
We currently calling gdk_display_map_keyval up to
once per key event per shortcut trigger, and that function
does an expensive loop over the entire keymap and
allocates an array. Avoid this by caching the entries
in a single array, and have a lookup table for finding
the entries for a keyval.
To do this, change the GdkKeymap.get_entries_for_keyval
signature, and change the ::keys-changed signal to be
RUN_FIRST, since we want to clear the cache in the class
handler before running signal handlers. These changes are
possible now, since keymaps are no longer public API.
nana-4 [Thu, 30 Apr 2020 14:15:04 +0000 (23:15 +0900)]
Adwaita: Use a mixin for visible focus rings
The focus-ring() mixin allows we to flexibly style the focus ring for
each widget. By using this, we can get rid of the "Outlines" section,
which is out of place in the _common.scss file.
This commit also has the following changes:
- Transition the focus rings on most widgets.
- Add a missing focus ring to iconview.
- Move the expander-widget focus ring to its title.
- Move the notebook focus ring to its checked tab.
Closes https://gitlab.gnome.org/GNOME/gtk/-/issues/2653
Daniel Mustieles [Thu, 30 Apr 2020 10:53:45 +0000 (12:53 +0200)]
Updated Spanish translation
Daniel Mustieles [Thu, 30 Apr 2020 10:53:01 +0000 (12:53 +0200)]
Updated Spanish translation
Matthias Clasen [Thu, 30 Apr 2020 01:31:36 +0000 (01:31 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
docs: Move menu model docs
See merge request GNOME/gtk!1799
Matthias Clasen [Thu, 30 Apr 2020 00:27:32 +0000 (20:27 -0400)]
docs: Move menu model docs
It makes more sense to document the menu model XML
format in the GtkPopoverMenu docs than in
GtkApplicationWindow.
Matthias Clasen [Wed, 29 Apr 2020 22:14:09 +0000 (22:14 +0000)]
Merge branch 'win32-new-runner' into 'master'
CI: Switch to new Windows runners
See merge request GNOME/gtk!1797
Yuri Chornoivan [Wed, 29 Apr 2020 20:16:31 +0000 (20:16 +0000)]
Update Ukrainian translation
Yuri Chornoivan [Wed, 29 Apr 2020 20:15:38 +0000 (20:15 +0000)]
Update Ukrainian translation
Christoph Reiter [Wed, 29 Apr 2020 17:36:40 +0000 (19:36 +0200)]
CI: Switch to new Windows runners
They use powershell instead of cmd.exe, use the tag win32-ps instead of win32,
and run Windows 2016 instead of 2012r2.
The old runners will be switched off in the comming weeks.
Matthias Clasen [Wed, 29 Apr 2020 15:29:02 +0000 (15:29 +0000)]
Merge branch 'soundcheck' into 'master'
Add a quick sound test
See merge request GNOME/gtk!1796
Matthias Clasen [Wed, 29 Apr 2020 14:54:40 +0000 (10:54 -0400)]
Add a quick sound test
Just to show that our media infrastructure is up
to playing little beeps and bings.
Emmanuele Bassi [Wed, 29 Apr 2020 13:39:44 +0000 (13:39 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Ebassi/for master
See merge request GNOME/gtk!1795
Emmanuele Bassi [Wed, 29 Apr 2020 11:49:35 +0000 (12:49 +0100)]
docs: Link the license file from the README
Emmanuele Bassi [Wed, 29 Apr 2020 11:49:05 +0000 (12:49 +0100)]
docs: Link the contribution guide from the README
Hopefully people will read it.
Emmanuele Bassi [Wed, 29 Apr 2020 11:47:57 +0000 (12:47 +0100)]
docs: Update link to the discussion forum
The README file still links to the old web page about mailing lists; the
link is now a 404 after the website redesign, and we don't use mailing
lists any more, in favour of Discourse.
Matthias Clasen [Wed, 29 Apr 2020 11:34:07 +0000 (11:34 +0000)]
Merge branch 'wip/jtojnar/join-paths' into 'master'
build: clean up .pc generation
See merge request GNOME/gtk!1793
Jan Tojnar [Wed, 29 Apr 2020 05:42:38 +0000 (07:42 +0200)]
build: clean up .pc generation
Path concatenation is much nicer than the unwieldy format method.
Since paths returned by get_option are relative to prefix, they will be joined as before.
As a bonus, this fixes weird platforms like NixOS that actually pass absolute includedir under a different prefix.
Matthias Clasen [Wed, 29 Apr 2020 04:47:39 +0000 (04:47 +0000)]
Merge branch 'popup-positioning-fix' into 'master'
popover: Fix repositioning logic
See merge request GNOME/gtk!1792